CircleCI 2.0 migration #1109
Merged
CircleCI 2.0 migration #1109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create new tox label for plot_ly
|
Ok, I got the tests running for a few configurations. I'm making each tox configuration a separate workflow so that testing the different configurations can happen in parallel. I took the opportunity to split out the tests that interact with plot.ly into a separate directory We need to add configurations for Python 3.6 and 3.7 and we can drop 3.3 since it's past end of life. |
core and core+optional on 2.7, 3.4, 3.5, 3.6, and 3.7 plot_ly on 2.7, 3.4, and 3.7
They have the same dependencies as core. The optional test jobs run the core tests because they have a different set of dependencies
These require the optional dependencies
This reverts commit 05fc89b.
Revert "Add tox caching for 2.7-core" This reverts commit 7a8a88b.
Not usually needed, but occasionally these commands have exceeded 10m
Closed
|
Alright, time to merge this thing. Goodbye CircleCI 1.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of test suite to 2.0, with improvements. Thanks to @scjody for the reminders 🙂
General approach: There is now a workflow for each Python version / test suite combination. This way all of the jobs can run in parallel. I also refactored the
coretests to pull out the tests that rely onplot.lyinteraction. These are currently the slowest tests, and pulling them out means that the core tests run really fast. It also means that if there is an intermittent failure due to plot.ly communication, we can restart only the plot.ly tests for the particular version of Python that had the failure.Updates:
Add useful cachingCaching tox sped builds up by a minute at most and would add a lot of extra complexity to the build file. So holding off for now.Future testing wishlist: #1113
cc @cldougl @chriddyp @Kully @scjody