Fix single cone #2647
Merged
Fix single cone #2647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "u": [0], "v": [0], "w": [2], | ||
| "colorscale": "Greens", | ||
| "showscale": false | ||
| } |
There was a problem hiding this comment.
Just to play devil's advocate re: autoscale - perhaps the single-cone mock should really be just one single cone, so the data has zero range without considering the cone itself? And multi-trace could be incorporated into another mock?
There was a problem hiding this comment.
yeah good call -> 7da71ae
|
Beautiful! Thanks for cleaning up multitrace and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up on #2641, bringing in @kig's gl-vis/gl-cone3d#9 and a few other cone tweaks.
cc @alexcjohnson