This repository was archived by the owner on Jun 4, 2024. It is now read-only.
ADD deletePlot method and example #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💃 |
|
|
||
| if (res.statusCode === 200) { | ||
|
|
||
| var msg = 'Successfully deleted plot: ' + self.username + ':' + fid; |
There was a problem hiding this comment.
what is returned in the res on success?
There was a problem hiding this comment.
the figure, I don't think we want to pass that through @bpostlethwaite but we can if thats whatcha want!
There was a problem hiding this comment.
yeh lets give the user as much data as we can - they can ignore it
|
💃 |
|
Yes, correct. I got the semantics mixed up, changing now! |
|
💃 |
alexander-daniel
added a commit
that referenced
this pull request
Oct 26, 2015
ADD deletePlot method and example
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will Resolve: #18
@etpinard @bpostlethwaite
What do you guys think? If y'all like it, I'll whip up some documentation for the new method!