Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable a default delimiter for parsing behaviour #94

Merged
merged 1 commit into from
Oct 3, 2016

Conversation

blakeembrey
Copy link
Member

@DylanPiercey - this might help you with handling hostnames. Let me know 😄

@DylanPiercey
Copy link

@blakeembrey looks sweet to me, thanks for looking into working with hostnames.

Currently the lib works fine for me with hostnames and I am having a little trouble following exactly whats changed in terms of functionality. Could you elaborate what this commit has fixed or changed at a high level?

@blakeembrey
Copy link
Member Author

blakeembrey commented Oct 2, 2016

Yes, sorry. I enabled delimiter to be passed in as a parse option. Before it assumed the default delimiter to always be /. The only place this would come up is in :foo+.com or :foo*.com where it'd assume a/b/c instead of a.b.c because of the default delimiter character.

@coveralls
Copy link

coveralls commented Oct 2, 2016

Coverage Status

Coverage increased (+0.004%) to 99.363% when pulling 7b351aa on default-delimiter into 9932d18 on master.

@DylanPiercey
Copy link

Ah cool, thats sweet. I saw the delimiter option but wasn't exactly sure what it was doing.

I have never personally had a situation where I wanted one or more domains in a group but this is sweet functionality to add and will definitely help people (like me) who might have guessed that would work before :p.

Would love to see this merged so I can update Rill :D.

Thanks for your work!

@coveralls
Copy link

coveralls commented Oct 2, 2016

Coverage Status

Coverage increased (+0.004%) to 99.363% when pulling c9a4c67 on default-delimiter into 9932d18 on master.

@blakeembrey blakeembrey merged commit 44c69d5 into master Oct 3, 2016
@blakeembrey blakeembrey deleted the default-delimiter branch October 3, 2016 17:40
MUDev1994 pushed a commit to MUDev1994/path-to-regexp that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants