Add a bunch of stubs #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrekelmans
commented
Jan 20, 2020
| interface EventSubscriberInterface | ||
| { | ||
| /** | ||
| * @return array<string, string|array<string, int>|array<int, string|array<string, int>|array<int, string>>> |
There was a problem hiding this comment.
This is clearly documented at https://github.com/symfony/symfony/blob/master/src/Symfony/Component/EventDispatcher/EventSubscriberInterface.php and tested against a codebase that uses all the different structures.
|
I'll have a proper look a bit later, but it looks good. Thanks. |
nusje2000
approved these changes
Jan 21, 2020
nvdbeek
approved these changes
Jan 22, 2020
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly adding
array<mixed>where symfony documentsarray(phpstan will complain about this on max level when implementing these interfaces).Also added an "empty"
ContainerBuilderstub, since phpstan complained about not knowing the class when seeing it inExtensionInterface.stub. If there's another way to fix this please let me know.These changes are based off of symfony 4.4 and tested on a medium to large-ish codebase.