FormInterface::getErrors could have a dynamic return extension

[VincentLanglet]

Currently, its return type is a FormErrorIterator with inside
Symfony\Component\Form\FormError|Symfony\Component\Form\FormErrorIterator

The phpdoc is

/**
     * Returns the errors of this form.
     *
     * @param bool $deep    Whether to include errors of child forms as well
     * @param bool $flatten Whether to flatten the list of errors in case
     *                      $deep is set to true
     *
     * @return FormErrorIterator An iterator over the {@link FormError}
     *                           instances that where added to this form
     */
    public function getErrors(bool $deep = false, bool $flatten = true);

So I would say it's always an iterator on Symfony\Component\Form\FormError, except if the parameter true, false are provided.

[mitelg]

I also just stumbled upon that and would love to see that, too 😊 👍

[VincentLanglet]

I also just stumbled upon that and would love to see that, too 😊 👍

This shouldn't be too hard to implement ; do you want to make a try ? @mitelg

[mitelg]

If you can hint me where to start and maybe even an example where I can take things from, I would like to give it a try 😁

[VincentLanglet]

https://github.com/phpstan/phpstan-symfony/blob/master/src/Type/Symfony/RequestDynamicReturnTypeExtension.php
can be a good example.

You'll have to implement your own logic inside getTypeFromMethodCall, but check like (new ConstantBooleanType(true))->isSuperTypeOf($argType) will be the same

[mitelg]

I tried to start and currently I am stuck at defining the new return type. I think i need to return new ObjectType(FormErrorIterator::class) in the getTypeFromMethodCall but how do I define the generic type?

[VincentLanglet]

You have generics here: https://github.com/phpstan/phpstan-src/tree/master/src/Type/Generic

[ondrejmirtes]

Documentation is here: https://phpstan.org/developing-extensions/dynamic-return-type-extensions

[ondrejmirtes]

Fixed by #228

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.