Skip to content

Rules: Use more specific node-type #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Rules: Use more specific node-type #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Rules/PHPUnit/AssertSameBooleanExpectedRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,22 +3,22 @@
namespace PHPStan\Rules\PHPUnit;

use PhpParser\Node;
use PhpParser\Node\Expr\CallLike;
use PhpParser\Node\Expr\ConstFetch;
use PhpParser\NodeAbstract;
use PHPStan\Analyser\Scope;
use PHPStan\Rules\Rule;
use PHPStan\Rules\RuleErrorBuilder;
use function count;

/**
* @implements Rule<NodeAbstract>
* @implements Rule<CallLike>
*/
class AssertSameBooleanExpectedRule implements Rule
{

public function getNodeType(): string
{
return NodeAbstract::class;
return CallLike::class;
}

public function processNode(Node $node, Scope $scope): array
Expand Down
6 changes: 3 additions & 3 deletions src/Rules/PHPUnit/AssertSameNullExpectedRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,22 +3,22 @@
namespace PHPStan\Rules\PHPUnit;

use PhpParser\Node;
use PhpParser\Node\Expr\CallLike;
use PhpParser\Node\Expr\ConstFetch;
use PhpParser\NodeAbstract;
use PHPStan\Analyser\Scope;
use PHPStan\Rules\Rule;
use PHPStan\Rules\RuleErrorBuilder;
use function count;

/**
* @implements Rule<NodeAbstract>
* @implements Rule<CallLike>
*/
class AssertSameNullExpectedRule implements Rule
{

public function getNodeType(): string
{
return NodeAbstract::class;
return CallLike::class;
}

public function processNode(Node $node, Scope $scope): array
Expand Down
6 changes: 3 additions & 3 deletions src/Rules/PHPUnit/AssertSameWithCountRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,22 +4,22 @@

use Countable;
use PhpParser\Node;
use PhpParser\NodeAbstract;
use PhpParser\Node\Expr\CallLike;
use PHPStan\Analyser\Scope;
use PHPStan\Rules\Rule;
use PHPStan\Rules\RuleErrorBuilder;
use PHPStan\Type\ObjectType;
use function count;

/**
* @implements Rule<NodeAbstract>
* @implements Rule<CallLike>
*/
class AssertSameWithCountRule implements Rule
{

public function getNodeType(): string
{
return NodeAbstract::class;
return CallLike::class;
}

public function processNode(Node $node, Scope $scope): array
Expand Down
Loading