Skip to content

Commit 9686cda

Browse files
committed
Updated coding standard
1 parent 5115c2b commit 9686cda

File tree

4 files changed

+21
-18
lines changed

4 files changed

+21
-18
lines changed

composer.json

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,13 @@
1515
"phpunit/phpunit": "^7.0"
1616
},
1717
"require-dev": {
18-
"consistence/coding-standard": "^2.0",
19-
"jakub-onderka/php-parallel-lint": "^0.9.2",
18+
"consistence/coding-standard": "^3.0.1",
19+
"dealerdirect/phpcodesniffer-composer-installer": "^0.4.4",
20+
"jakub-onderka/php-parallel-lint": "^1.0",
2021
"phing/phing": "^2.16.0",
2122
"phpstan/phpstan-strict-rules": "^0.10",
2223
"satooshi/php-coveralls": "^1.0",
23-
"slevomat/coding-standard": "^3.3.0"
24+
"slevomat/coding-standard": "^4.5.2"
2425
},
2526
"autoload": {
2627
"psr-4": {

phpcs.xml

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,10 @@
22
<ruleset name="PHPStan PHPUnit extensions and rules">
33
<rule ref="vendor/consistence/coding-standard/Consistence/ruleset.xml">
44
<exclude name="Squiz.Functions.GlobalFunction.Found"/>
5-
</rule>
6-
<rule ref="vendor/slevomat/coding-standard/SlevomatCodingStandard/ruleset.xml">
7-
<exclude name="SlevomatCodingStandard.Files.TypeNameMatchesFileName"/>
85
<exclude name="SlevomatCodingStandard.Namespaces.FullyQualifiedClassNameAfterKeyword"/>
9-
<exclude name="SlevomatCodingStandard.Namespaces.UseOnlyWhitelistedNamespaces"/>
6+
<exclude name="SlevomatCodingStandard.Namespaces.FullyQualifiedClassNameInAnnotation"/>
7+
<exclude name="SlevomatCodingStandard.Namespaces.FullyQualifiedExceptions"/>
108
<exclude name="SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly"/>
11-
<exclude name="SlevomatCodingStandard.TypeHints.TypeHintDeclaration.MissingTraversableParameterTypeHintSpecification"/>
12-
<exclude name="SlevomatCodingStandard.TypeHints.TypeHintDeclaration.MissingTraversableReturnTypeHintSpecification"/>
13-
<exclude name="SlevomatCodingStandard.Namespaces.FullyQualifiedClassNameInAnnotation.NonFullyQualifiedClassName"/>
14-
<exclude name="SlevomatCodingStandard.Namespaces.FullyQualifiedGlobalConstants"/>
15-
<exclude name="SlevomatCodingStandard.Namespaces.FullyQualifiedGlobalFunctions"/>
169
</rule>
1710
<rule ref="SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses">
1811
<properties>
@@ -32,5 +25,18 @@
3225
"/>
3326
</properties>
3427
</rule>
28+
<rule ref="SlevomatCodingStandard.ControlStructures.AssignmentInCondition"/>
29+
<rule ref="SlevomatCodingStandard.ControlStructures.DisallowEqualOperators"/>
30+
<rule ref="SlevomatCodingStandard.ControlStructures.EarlyExit"/>
31+
<rule ref="SlevomatCodingStandard.Classes.SuperfluousAbstractClassNaming"/>
32+
<rule ref="SlevomatCodingStandard.Classes.SuperfluousInterfaceNaming"/>
33+
<!-- <rule ref="SlevomatCodingStandard.ControlStructures.DisallowShortTernaryOperator"/>-->
34+
<!-- <rule ref="SlevomatCodingStandard.Namespaces.RequireOneNamespaceInFile"/> -->
35+
<!-- <rule ref="SlevomatCodingStandard.PHP.ShortList"/> -->
36+
<rule ref="SlevomatCodingStandard.Files.TypeNameMatchesFileName">
37+
<properties>
38+
<property name="rootNamespaces" type="array" value="src=>PHPStan,tests=>PHPStan"/>
39+
</properties>
40+
</rule>
3541
<exclude-pattern>tests/*/data</exclude-pattern>
3642
</ruleset>

src/Type/PHPUnit/MockBuilderDynamicReturnTypeExtension.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,7 @@
1414
class MockBuilderDynamicReturnTypeExtension implements \PHPStan\Type\DynamicMethodReturnTypeExtension, \PHPStan\Reflection\BrokerAwareExtension
1515
{
1616

17-
/**
18-
* @var \PHPStan\Broker\Broker
19-
*/
17+
/** @var \PHPStan\Broker\Broker */
2018
private $broker;
2119

2220
public function setBroker(Broker $broker): void

src/Type/PHPUnit/MockBuilderType.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,7 @@
77
class MockBuilderType extends \PHPStan\Type\ObjectType
88
{
99

10-
/**
11-
* @var string
12-
*/
10+
/** @var string */
1311
private $mockedClass;
1412

1513
public function __construct(

0 commit comments

Comments
 (0)