Updated type descriptions in test for detecting wrong asserts

ondrejmirtes · ondrejmirtes · commit 5115c2bfb80b · 2018-04-02T12:47:24.000+02:00
diff --git a/tests/Rules/PHPUnit/AssertSameMethodDifferentTypesRuleTest.php b/tests/Rules/PHPUnit/AssertSameMethodDifferentTypesRuleTest.php
@@ -28,55 +28,55 @@ public function testRule(): void
 	{
 		$this->analyse([__DIR__ . '/data/assert-same.php'], [
 			[
-				'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				'Call to method PHPUnit\Framework\Assert::assertSame() with string and int(1) will always evaluate to false.',
 				10,
 			],
 			[
-				'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				'Call to method PHPUnit\Framework\Assert::assertSame() with string and stdClass will always evaluate to false.',
 				11,
 			],
 			[
-				'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				'Call to method PHPUnit\Framework\Assert::assertSame() with int(1) and string will always evaluate to false.',
 				12,
 			],
 			[
-				'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				'Call to method PHPUnit\Framework\Assert::assertSame() with string and int will always evaluate to false.',
 				13,
 			],
 			[
-				'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				'Call to method PHPUnit\Framework\Assert::assertSame() with array<int(0)|int(1), string> and array<int(0)|int(1), int(1)|int(2)> will always evaluate to false.',
 				14,
 			],
 			[
-				'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				'Call to method PHPUnit\Framework\Assert::assertSame() with array<string> and array<int> will always evaluate to false.',
 				39,
 			],
 			[
-				'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to true.',
+				'Call to method PHPUnit\Framework\Assert::assertSame() with int(1) and int(1) will always evaluate to true.',
 				44,
 			],
 			[
-				'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				'Call to method PHPUnit\Framework\Assert::assertSame() with array<int(0), string> and array<int(0)|int(1), string> will always evaluate to false.',
 				45,
 			],
 			[
-				'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to true.',
+				'Call to method PHPUnit\Framework\Assert::assertSame() with string and string will always evaluate to true.',
 				46,
 			],
 			[
-				'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				'Call to method PHPUnit\Framework\Assert::assertSame() with string and string will always evaluate to false.',
 				47,
 			],
 			[
-				'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to true.',
+				'Call to method PHPUnit\Framework\Assert::assertSame() with stdClass and stdClass will always evaluate to true.',
 				48,
 			],
 			[
-				'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				'Call to method PHPUnit\Framework\Assert::assertSame() with array<int(0), string> and array<int(0)|int(1), int(1)|string> will always evaluate to false.',
 				51,
 			],
 			[
-				'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				'Call to method PHPUnit\Framework\Assert::assertSame() with array<int(0)|int(1)|int(2), float(3.000000)|int(2)|string> and array<int(0)|int(1), int(1)|string> will always evaluate to false.',
 				52,
 			],
 		]);
diff --git a/tests/Rules/PHPUnit/AssertSameStaticMethodDifferentTypesRuleTest.php b/tests/Rules/PHPUnit/AssertSameStaticMethodDifferentTypesRuleTest.php
@@ -28,27 +28,27 @@ public function testRule(): void
 	{
 		$this->analyse([__DIR__ . '/data/assert-same.php'], [
 			[
-				'Call to static method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				'Call to static method PHPUnit\Framework\Assert::assertSame() with string and int(2) will always evaluate to false.',
 				16,
 			],
 			[
-				'Call to static method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				'Call to static method PHPUnit\Framework\Assert::assertSame() with string and int(2) will always evaluate to false.',
 				17,
 			],
 			[
-				'Call to static method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				'Call to static method PHPUnit\Framework\Assert::assertSame() with string and int(2) will always evaluate to false.',
 				18,
 			],
 			[
-				'Call to static method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				'Call to static method PHPUnit\Framework\Assert::assertSame() with int(1) and int(2) will always evaluate to false.',
 				53,
 			],
 			[
-				'Call to static method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				'Call to static method PHPUnit\Framework\Assert::assertSame() with int(1) and int(2) will always evaluate to false.',
 				54,
 			],
 			[
-				'Call to static method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				'Call to static method PHPUnit\Framework\Assert::assertSame() with int(1) and int(2) will always evaluate to false.',
 				55,
 			],
 		]);

Original file line number	Diff line number	Diff line change
`@@ -28,55 +28,55 @@ public function testRule(): void`
`28`	`28`	`{`
`29`	`29`	`$this->analyse([__DIR__ . '/data/assert-same.php'], [`
`30`	`30`	`[`
`31`		`- 'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',`
	`31`	`+ 'Call to method PHPUnit\Framework\Assert::assertSame() with string and int(1) will always evaluate to false.',`
`32`	`32`	`10,`
`33`	`33`	`],`
`34`	`34`	`[`
`35`		`- 'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',`
	`35`	`+ 'Call to method PHPUnit\Framework\Assert::assertSame() with string and stdClass will always evaluate to false.',`
`36`	`36`	`11,`
`37`	`37`	`],`
`38`	`38`	`[`
`39`		`- 'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',`
	`39`	`+ 'Call to method PHPUnit\Framework\Assert::assertSame() with int(1) and string will always evaluate to false.',`
`40`	`40`	`12,`
`41`	`41`	`],`
`42`	`42`	`[`
`43`		`- 'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',`
	`43`	`+ 'Call to method PHPUnit\Framework\Assert::assertSame() with string and int will always evaluate to false.',`
`44`	`44`	`13,`
`45`	`45`	`],`
`46`	`46`	`[`
`47`		`- 'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',`
	`47`	`+ 'Call to method PHPUnit\Framework\Assert::assertSame() with array<int(0)\|int(1), string> and array<int(0)\|int(1), int(1)\|int(2)> will always evaluate to false.',`
`48`	`48`	`14,`
`49`	`49`	`],`
`50`	`50`	`[`
`51`		`- 'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',`
	`51`	`+ 'Call to method PHPUnit\Framework\Assert::assertSame() with array<string> and array<int> will always evaluate to false.',`
`52`	`52`	`39,`
`53`	`53`	`],`
`54`	`54`	`[`
`55`		`- 'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to true.',`
	`55`	`+ 'Call to method PHPUnit\Framework\Assert::assertSame() with int(1) and int(1) will always evaluate to true.',`
`56`	`56`	`44,`
`57`	`57`	`],`
`58`	`58`	`[`
`59`		`- 'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',`
	`59`	`+ 'Call to method PHPUnit\Framework\Assert::assertSame() with array<int(0), string> and array<int(0)\|int(1), string> will always evaluate to false.',`
`60`	`60`	`45,`
`61`	`61`	`],`
`62`	`62`	`[`
`63`		`- 'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to true.',`
	`63`	`+ 'Call to method PHPUnit\Framework\Assert::assertSame() with string and string will always evaluate to true.',`
`64`	`64`	`46,`
`65`	`65`	`],`
`66`	`66`	`[`
`67`		`- 'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',`
	`67`	`+ 'Call to method PHPUnit\Framework\Assert::assertSame() with string and string will always evaluate to false.',`
`68`	`68`	`47,`
`69`	`69`	`],`
`70`	`70`	`[`
`71`		`- 'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to true.',`
	`71`	`+ 'Call to method PHPUnit\Framework\Assert::assertSame() with stdClass and stdClass will always evaluate to true.',`
`72`	`72`	`48,`
`73`	`73`	`],`
`74`	`74`	`[`
`75`		`- 'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',`
	`75`	`+ 'Call to method PHPUnit\Framework\Assert::assertSame() with array<int(0), string> and array<int(0)\|int(1), int(1)\|string> will always evaluate to false.',`
`76`	`76`	`51,`
`77`	`77`	`],`
`78`	`78`	`[`
`79`		`- 'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',`
	`79`	`+ 'Call to method PHPUnit\Framework\Assert::assertSame() with array<int(0)\|int(1)\|int(2), float(3.000000)\|int(2)\|string> and array<int(0)\|int(1), int(1)\|string> will always evaluate to false.',`
`80`	`80`	`52,`
`81`	`81`	`],`
`82`	`82`	`]);`
Original file line number	Diff line number	Diff line change
`@@ -28,27 +28,27 @@ public function testRule(): void`
`28`	`28`	`{`
`29`	`29`	`$this->analyse([__DIR__ . '/data/assert-same.php'], [`
`30`	`30`	`[`
`31`		`- 'Call to static method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',`
	`31`	`+ 'Call to static method PHPUnit\Framework\Assert::assertSame() with string and int(2) will always evaluate to false.',`
`32`	`32`	`16,`
`33`	`33`	`],`
`34`	`34`	`[`
`35`		`- 'Call to static method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',`
	`35`	`+ 'Call to static method PHPUnit\Framework\Assert::assertSame() with string and int(2) will always evaluate to false.',`
`36`	`36`	`17,`
`37`	`37`	`],`
`38`	`38`	`[`
`39`		`- 'Call to static method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',`
	`39`	`+ 'Call to static method PHPUnit\Framework\Assert::assertSame() with string and int(2) will always evaluate to false.',`
`40`	`40`	`18,`
`41`	`41`	`],`
`42`	`42`	`[`
`43`		`- 'Call to static method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',`
	`43`	`+ 'Call to static method PHPUnit\Framework\Assert::assertSame() with int(1) and int(2) will always evaluate to false.',`
`44`	`44`	`53,`
`45`	`45`	`],`
`46`	`46`	`[`
`47`		`- 'Call to static method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',`
	`47`	`+ 'Call to static method PHPUnit\Framework\Assert::assertSame() with int(1) and int(2) will always evaluate to false.',`
`48`	`48`	`54,`
`49`	`49`	`],`
`50`	`50`	`[`
`51`		`- 'Call to static method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',`
	`51`	`+ 'Call to static method PHPUnit\Framework\Assert::assertSame() with int(1) and int(2) will always evaluate to false.',`
`52`	`52`	`55,`
`53`	`53`	`],`
`54`	`54`	`]);`