Deprecation found that is actually the solution to the problem

[heiglandreas]

I encountered a rather specific problem recently with the phpstan-deprecation-rule, more concrete with the FetchingClassConstOfDeprecatedClassRule.

When I run phpstan over a sample project I get the following message:

  5      Fetching deprecated class constant LAST_USERNAME of class       
         Symfony\Bundle\SecurityBundle\Security:                         
         since Symfony 6.2, use                                          
         \Symfony\Bundle\SecurityBundle\Security::LAST_USERNAME instead 

This is somewhat puzzling...

I have prepared a small gist that one can check out to reproduce the issue:

git clone https://gist.github.com/ddb23f85813820a24c4cd26250d844ce.git
cd ddb23f85813820a24c4cd26250d844ce
composer install
./vendor/bin/phpstan

Sadly so far I wasn't able to track down where the issue is actually happening. I only dug down so far that the \Symfony\Bundle\SecurityBundle\Security class is extending a deprecated class and the \Symfony\Bundle\SecurityBundle\Security::LAST_USERNAME const is overwriting the constant of the extended, deprecated, class.

But it looks like there is more to it as trying to reproduce that with an exaple where I recreate the classes myself didn't work. So there seems to be a bit more involved.

When I comment out the FetchingClassConstOfDeprecatedClassRule in the config file of the phpstan-deprecation-rule everything works as intended. So that one is for sure involved somehow...

[ondrejmirtes]

The issue is that class Security extends LegacySecurity, LegacySecurity is Symfony\Component\Security\Core\Security and that class has this:

    /**
     * @deprecated since Symfony 6.2, use \Symfony\Bundle\SecurityBundle\Security::LAST_USERNAME instead
     */
    public const LAST_USERNAME = '_security.last_username';

@deprecated annotations are inherited, you can break the inheritance chain by introducing @not-deprecated. Described in the documentation: https://phpstan.org/writing-php-code/phpdocs-basics#deprecations

You can do that either in the original source code, or by providing a stub file: https://phpstan.org/user-guide/stub-files

I'd accept these stubs in phpstan-symfony, ideally for all similar situations in Symfony at once.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.