Add socket_atmark unit test #9978
Open
+53
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
socket_atmark_test
branch
from
79a6ca4 to
7263019
Compare
bukka
reviewed
Nov 20, 2022
ext/sockets/tests/socket_atmark.phpt
Outdated
| --SKIPIF-- | ||
| <?php | ||
|
|
||
| if (getenv("SKIP_ONLINE_TESTS")) { |
There was a problem hiding this comment.
would be actually great not to do add another online test as those don't run in the pipeline. Would be great to convert to the server / client one which should still work.
bukka
reviewed
Nov 20, 2022
ext/sockets/tests/socket_atmark.phpt
Outdated
Comment on lines
14
to
32
| $s_c = socket_create(AF_INET, SOCK_STREAM, SOL_TCP) or die("socket_create failed"); | ||
| $s_bind = socket_bind($s_c, '0.0.0.0') or die("socket_bind failed"); | ||
| $s_conn = socket_connect($s_c, 'www.php.net', 80) or die("socket_connect failed"); | ||
| $string = "no chance of socket_atmark returning true"; | ||
| $len = strlen($string); | ||
| $s_w = socket_send($s_c, $string, $len, 0); | ||
| if ($s_w != $len) | ||
| die("socket_send failed"); | ||
| if (socket_atmark($s_c) === FALSE) { | ||
| if (socket_recv($s_c, $buf, $len, 0) != $len) | ||
| die("socket_recv failed"); | ||
| echo "not OOB"; | ||
| } else { | ||
| $buf = ""; | ||
| if (socket_recv($s_c, $buf, 1, MSG_OOB) === FALSE) | ||
| die("socket_recv failed"); | ||
| echo "OOB"; | ||
| } | ||
| socket_close($s_c); |
devnexen
force-pushed
the
socket_atmark_test
branch
from
7263019 to
03bf0ee
Compare
cmb69
reviewed
Nov 21, 2022
ext/sockets/tests/socket_atmark.phpt
Outdated
Comment on lines
8
to
10
| if (strtolower(substr(PHP_OS, 0, 3)) == 'win') { | ||
| die("skip Windows"); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (strtolower(substr(PHP_OS, 0, 3)) == 'win') { | |
| die("skip Windows"); | |
| } | |
| if (PHP_OS_FAMILY !== 'Windows') die("skip not for Windows"); |
devnexen
force-pushed
the
socket_atmark_test
branch
from
03bf0ee to
72cac52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.