Skip to content

Fix for FR #61602 Allow access to name of constant used as default value #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 0 commits into from
May 31, 2012

Conversation

reeze
Copy link
Contributor

@reeze reeze commented May 23, 2012

Hi,
This is an improved commit for 054f3e3,
it fixed the previous commit's C99 compiler compatibility, the main change is do not use GET_REFLECTION_OBJECT_PTR macro directly. thanks Nuno.

@laruence may you take look? thanks.

Thanks.

@reeze
Copy link
Contributor Author

reeze commented May 24, 2012

That is used to avoid double call _reflection_param_get_default_param, and _reflection_param_get_default_param() will not return null most of the time. if on exception or error, the later function _reflection_param_get_default_precv() will return null too, so...

@laruence
Copy link
Member

how about :
if (!(param = _reflection_param_get_default_param(INTERNAL_FUNCTION_PARAM_PASSTHRU)
|| !(precv = _reflection_param_get_default_precv(INTERNAL_FUNCTION_PARAM_PASSTHRU, param)) {
return;
}

@laruence
Copy link
Member

actually, I didn't understand what you mean,, you are double calling it ...

@reeze
Copy link
Contributor Author

reeze commented May 24, 2012

Oh, I got you.

@reeze
Copy link
Contributor Author

reeze commented May 24, 2012

@laruence useless strlen & double call eliminated :)

Thank you!

@reeze
Copy link
Contributor Author

reeze commented May 30, 2012

Indeed. they should be. I will update that soon, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants