Reduce memory usage when unserializing packed arrays of size 1 #7691
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, PHP's unserialize() would unconditionally convert a packed array to
an associative(hashed) array to solve the problem of
[0 => $v1, 'key' => $v2]
starting out as a packed array but becoming an associative array,
causing the raw zval pointer to the value for $v1 to have changed.
Additionally, reduce memory usage when calling
__unserialize
with arrays ofsize 0 or 1
(e.g. for user-defined functions that store the passed in array as a property)
I looked into repacking arrays of size 2+ after the unserializer no longer needed them, but ran into these issues:
Benchmark
Before (PHP 8.2)
After (PHP 8.2)