Micro-optimizations for WeakMap #7670
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip WeakMap lookup check for assertion in non-debug builds The expected performance impact is negligible, the memory will be loaded from main memory into cache anyway for the call to zend_hash_index_del. Use the `zend_hash_lookup` helper to optimize adding a WeakMap entry if the entry doesn't already exist.
TysonAndre
force-pushed
the
weakmap-skip-check
branch
from
cc3c167 to
7a17858
Compare
nikic
approved these changes
Nov 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip WeakMap lookup check for assertion in non-debug builds
The expected performance impact is negligible,
the memory will be loaded from main memory into cache anyway
for the call to zend_hash_index_del.
Use the
zend_hash_lookuphelper to optimize adding a WeakMap entryif the entry doesn't already exist.
EDIT: Should have targeted
masteraccording toCONTRIBUTING.md- tests of Zend pass in master as well