Add more specific array return type hints for various extensions - part 5 #7471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
commented
Sep 6, 2021
| /** | ||
| * @return array<string, string>|false | ||
| * @alias litespeed_response_headers | ||
| */ | ||
| function apache_response_headers(): array|false {} |
There was a problem hiding this comment.
Unlike other SAPIs, litespeed makes apache_request_headers() and apache_response_headers() an alias of its own implementations. The former one can be safely changed (so that litespeed_request_headers() becomes the alias of apache_request_headers()), however the latter one cannot, since the return type is different (array|false vs array). Can we somehow remove the false return? Or what could we do in order to add apache_response_headers() to the optimizer func info?
kocsismate
added
the
Type Information
kocsismate
force-pushed
the
stub-array-6
branch
from
9179a4a to
2c18a11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.