Use zend_string_equals_* API some more #6979
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
force-pushed
the
more-string_equals_usage
branch
from
5ae9b34 to
5044d71
Compare
Girgias
force-pushed
the
more-string_equals_usage
branch
from
5044d71 to
1ebf2b5
Compare
nikic
approved these changes
May 14, 2021
| xmlNsPtr ns = NULL, curns; | ||
| char *strURI; | ||
| char *prefix; | ||
| char *prefix_char; |
Member
There was a problem hiding this comment.
This makes it sound like prefix is a single character...
Member
Author
There was a problem hiding this comment.
Yeah now that you mention it, any idea of a better name? Or should I rename this to prefix, and the zend_string to prefix_str?
| domain_name = domain; | ||
| } else { | ||
| domain_name = NULL; | ||
| if (domain != NULL && (ZSTR_LEN(domain) != 0) && !zend_string_equals_literal(domain, "0")) { |
Member
There was a problem hiding this comment.
Suggested change
| if (domain != NULL && (ZSTR_LEN(domain) != 0) && !zend_string_equals_literal(domain, "0")) { | |
| if (domain != NULL && ZSTR_LEN(domain) != 0 && !zend_string_equals_literal(domain, "0")) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it makes it clearer