Fix json_encode regression with JSON_PRETTY_PRINT #6811
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the json encoding behavior the same as it was prior to the memory optimizations added in f9f8c1c (for objects with declared properties) This is based on the code for the optimized case. Buggy output prior to this commit: ``` { "prop":"value"} ``` Correct output: ``` { "prop": "value" } ```
TysonAndre
commented
Mar 27, 2021
| echo json_encode($obj, JSON_PRETTY_PRINT), "\n"; | ||
| ?> | ||
| --EXPECT-- | ||
| {} |
There was a problem hiding this comment.
The output in php 8.1.0-dev after this patch matches what I'm seeing in php 7.4
I think the original patch was worth it to avoid an increase in memory usage caused by json_encode(), and shouldn't cause any invalid memory accesses - there may be a tiny change in output for edge cases involving JsonSerializable and regular objects, but I don't expect code to rely on that behavior
|
I think this is correct and the unit test should cover relevant cases - @dstogov @nikic @kocsismate this could take another look. If there are no objections I plan to merge this on tuesday, if this is approved I'll merge it earlier |
nikic
approved these changes
Mar 27, 2021
kamil-tekiela
pushed a commit
to kamil-tekiela/php-src
that referenced
this pull request
Apr 4, 2021
This makes the json encoding behavior the same as it was prior to the memory optimizations added in f9f8c1c (for objects with declared properties) This is based on the code for the unoptimized case below the changes. Buggy output prior to this commit: ``` { "prop":"value"} ``` Correct output: ``` { "prop": "value" } ``` Closes phpGH-6811
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the json encoding behavior the same as it was prior to the memory
optimizations added in f9f8c1c
(for objects with declared properties)
This is based on the code for the unoptimized case below the changes
Buggy output prior to this commit:
Correct output: