Promote warnings to exceptions in ext/ldap #6065
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 tasks
|
Calls to zend_zval_type_name with no attribute seems to cause build errors. The changes on themselves seems fine apart from this. |
kocsismate
force-pushed
the
ldap-warning
branch
from
61a88cf to
f32ed9d
Compare
|
@MCMic Thanks for the review! I've just fixed the build (hopefully), and I'm going to fix the tests now. |
|
@koksismate, please rebase to get rid of the Windows build error. |
kocsismate
force-pushed
the
ldap-warning
branch
from
f32ed9d to
d5a8b6b
Compare
kocsismate
force-pushed
the
ldap-warning
branch
from
d5a8b6b to
8c3f4ff
Compare
nikic
reviewed
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.