ValueError for empty path in stream code #5902
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AppVeyor failures legit. |
Girgias
force-pushed
the
stream-value-error
branch
from
6c793bd to
31b99d2
Compare
Girgias
force-pushed
the
stream-value-error
branch
from
31b99d2 to
367f430
Compare
nikic
reviewed
Jul 30, 2020
| @@ -2066,7 +2066,7 @@ PHPAPI php_stream *_php_stream_open_wrapper_ex(const char *path, const char *mod | |||
| } | |||
|
|
|||
| if (!path || !*path) { | |||
| php_error_docref(NULL, E_WARNING, "Filename cannot be empty"); | |||
| zend_value_error("Path cannot be empty"); | |||
There was a problem hiding this comment.
I believe we ended up using TypeError for this case everywhere else (because it's often checked by zpp).
There was a problem hiding this comment.
I thought TypeErrors were just in case the path contained a null byte?
There was a problem hiding this comment.
I checked again and indeed we use Value error for the empty case: https://heap.space/search?project=php-src&full=%22cannot+be+empty%22&defs=&refs=&path=&hist=&type=c
nikic
approved these changes
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how to go about the message content, I changed it to path as it seems more general, but can revert back to "filename"