Sodium warning to Exception #5880
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 tasks
Girgias
force-pushed
the
sodium-warning-to-error
branch
from
288a4cf to
dd4ed93
Compare
|
@jedisct1 any opinion on this? |
|
Hi! I'm not in favor of turning this into an error. There are perfectly valid scenarios where an empty password can be fine, especially in local, command-line applications. It can also be acceptable to use Argon2 as a KDF with an empty password, but a salt with enough entropy. The warning was a little addition for PHP, but other bindings don't treat empty passwords differently, so maybe we should keep things that way, if only for consistency. |
|
Agree with @jedisct1 on this. Personally I'd also drop the warning. |
|
As empty password handling is the only change here, I'm closing this per above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This promotes all the empty PWD warnings to exception.
I'm not sure if the last remaining warning about the "wrong size for the hashed password" should be converted too.