Remove proto comments #5758
Closed
Remove proto comments #5758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kocsismate, better now? :) |
|
@MaxSem Really nice! :) I had a quick look, and the PR mostly looked good to me! The only very small gotcha I saw was that the description is repeated in case of functions that have multiple aliases (e.g. in intl). I don't think you have to address these now, so I'm perfectly ok with keeping them for now. In the meanwhile, I'll convert my PR to remove the protos from tests as well. |
nikic
reviewed
Jun 24, 2020
ext/intl/collator/collator_attr.c
Outdated
| /* {{{ proto int collator_get_attribute( Collator $coll, int $attr ) | ||
| * Get collation attribute value. | ||
| /* {{{ * Get collation attribute value. }}} */ | ||
| /* {{{ * Get collation attribute value. |
There was a problem hiding this comment.
We should try to avoid these odd cases at least.
MaxSem
force-pushed
the
braces
branch
2 times, most recently
from
649c2ed to
960589c
Compare
nikic
approved these changes
Jul 2, 2020
ext/intl/converter/converter.c
Outdated
| @@ -103,8 +103,7 @@ static void php_converter_default_callback(zval *return_value, zval *zobj, zend_ | |||
| } | |||
| /* }}} */ | |||
|
|
|||
| /* {{{ proto void UConverter::toUCallback(int $reason, | |||
| string $source, string $codeUnits, | |||
| /* {{{ string $source, string $codeUnits, | |||
| int &$error) */ | |||
kocsismate
reviewed
Jul 6, 2020
They've been made obsolete by .stub.php files and are often outdated as they're not the source of truth.
|
I had a look at the new commit, and it looked good. So I took the liberty and merged this in order not to face any conflicts. @nikic If you find any formatting issues, I can also help sort them out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They've been made obsolete by .stub.php files and are often outdated as they're not the source of truth.