Cleanup SPL autoload implementation #5696
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this manifest in perf improvements regarding autoloading? |
|
@staabm Yes, this should slightly improve performance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes one level of indirection from the autoloading implementation. Instead of calling
spl_autoload_call(), which then calls the registered autoloaders, we introduce a directzend_autoloadhook.Additionally, we simplify handling by dropping special-casing of
spl_autoload, and instead registering the default autoloader just like any other one.This also fixes https://bugs.php.net/bug.php?id=71236 as a side-effect.