Convert some warnings to Error in zlib extension #4985
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If there are no objections I'll rebase and merge this next week. |
|
Shouldn't this line also be changed to throw? I was only scrolling to that function because I was interested in seeing whether partial data fed to a zlib inflate context would throw now with this PR. |
nikic
reviewed
Jan 3, 2020
No, this should not throw Error, as it's an expected condition. |
Girgias
force-pushed
the
zlib-warning-to-error
branch
from
ae719c0 to
d2ed399
Compare
nikic
approved these changes
Jan 8, 2020
71 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.