Promote the warning of array_key_exists() to exception #4887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #4572. |
|
Yes, I should have remembered about this PR (or at least checked for it). :D OK, not doing warning promotions certainly makes sense for |
|
@kocsismate Chaning |
|
That is, the argument should not be "string or integer", it should work based on the normal array key coercions that are used everywhere else where array accesses are performed. Only arrays and objects should result in a TypeError. |
kocsismate
force-pushed
the
standard-array-exceptions
branch
from
d065f42 to
04d25cd
Compare
kocsismate
changed the title
kocsismate
commented
Nov 5, 2019
kocsismate
commented
Nov 5, 2019
kocsismate
changed the title
kocsismate
force-pushed
the
standard-array-exceptions
branch
from
04d25cd to
7e3a206
Compare
nikic
reviewed
Nov 5, 2019
nikic
reviewed
Nov 5, 2019
kocsismate
commented
Nov 5, 2019
nikic
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not exactly sure if these promotions fall into the scope of the Engine Warnings RFC (are these errors suppressed commonly?), so feel free to close the PR in this case.
Also, I made two more promotions in the standard/array.c file, but these doesn't seem likely to happen (one of them is in an apparently not used macro and the other should never happen according to its comment).