Warnings become errors hash stream functions (other than hash_init) #4625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged as 960da6d Thanks. |
salathe
reviewed
Sep 7, 2019
| @@ -414,8 +414,8 @@ PHP_FUNCTION(hash_init) | |||
|
|
|||
| #define PHP_HASHCONTEXT_VERIFY(func, hash) { \ | |||
| if (!hash->context) { \ | |||
| php_error(E_WARNING, "%s(): supplied resource is not a valid Hash Context resource", func); \ | |||
| RETURN_NULL(); \ | |||
| zend_throw_error(NULL, "%s(): supplied resource is not a valid Hash Context resource", func); \ | |||
There was a problem hiding this comment.
Should this be a TypeError? See discussion on #4643
There was a problem hiding this comment.
Not really the same case, more a bad error message. It should probably say something along the lines of "can't reuse an already finalized HashContext" or so.
71 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.