Remove PHP_DEFINE m4 macro #4360
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just looked at what's going on with PHP_DEFINE and ... wat. Could you please look into migrating iconv to AC_DEFINE and drop this macro entirely? I get the idea behind it, but with everything else using AC_DEFINE and us including php_config.h (transitively) everywhere, this really doesn't make sense. |
petk
force-pushed
the
patch-configure-dead-code
branch
from
55d47bd to
b2f8722
Compare
petk
force-pushed
the
patch-configure-dead-code
branch
from
7e2eee9 to
7fb3387
Compare
PHP_DEFINE was introduced with the PHP 5 build system 9d9d39a and then refactored via 350de12. This simplifies includes. Also changed: - removed PHP_ATOM_INC define via DEFS variable - generated unused include directory removed - Remove include dir from DEFS - Remove also include dir from PDO checks
petk
force-pushed
the
patch-configure-dead-code
branch
from
7fb3387 to
d0d083c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This step was introduced with 350de12 and then changed later on so now it doesn't work anymore properly.