Skip to content

main: refactor implementation of set_time_limit() #19338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2025

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Jul 31, 2025

No description provided.

@Girgias Girgias marked this pull request as ready for review July 31, 2025 22:56
@Girgias Girgias requested a review from bukka as a code owner July 31, 2025 22:56
@Girgias Girgias requested a review from nielsdos August 2, 2025 14:39
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose you can technically also print the number to a stack buffer, but this works too

@Girgias
Copy link
Member Author

Girgias commented Aug 3, 2025

I suppose you can technically also print the number to a stack buffer, but this works too

The main reason I chose this approach is that to alter an INI setting you need a zend_string, so not sure if a stack buffer is the most helpful?

@Girgias Girgias merged commit 961412d into php:master Aug 3, 2025
9 checks passed
@Girgias Girgias deleted the main-set_time_limit-refactor branch August 3, 2025 15:17
@nielsdos
Copy link
Member

nielsdos commented Aug 3, 2025

I suppose you can technically also print the number to a stack buffer, but this works too

The main reason I chose this approach is that to alter an INI setting you need a zend_string, so not sure if a stack buffer is the most helpful?

I thought zend_alter_ini_entry_chars_ex would be usable directly, but it also creates a zend_string, so this is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants