Refactor op array loops in JIT #19335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reuse the helper zend_foreach_op_array() that we move to the zend_optimizer.h header to be usable in opcache. Note that applying this to other op_array loops is not easy because they either: - start from EG(persistent_classes_count) - or only apply to classes
iluuu1994
approved these changes
Jul 31, 2025
There was a problem hiding this comment.
Note that applying this to other op_array loops is not easy because they either:
- or only apply to classes
We could solve that part by simply splitting out that section of zend_foreach_op_array() into zend_foreach_method(). But for now this looks fine, given we can't use it for preload_link(), at least without complicating the API further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse the helper zend_foreach_op_array() that we move to the zend_optimizer.h header to be usable in opcache.
Note that applying this to other op_array loops is not easy because they either: