Fix incorrect anonymous class type name assertion #19316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since phpGH-17755 self and parent are compile-time resolved. We may now also encounter this type error at runtime outside of the class itself. Fixes phpGH-19304
|
@Girgias Agreed, though I don't think this assertion is super useful to begin with. |
I think I added them while trying to figure out all the cases where it was not being resolved at compile time, and clearly I didn't find all the cases :) |
|
This assertion was much older, actually. I.e. not added by yourself. 🙂
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since GH-17755 self and parent are compile-time resolved. We may now also encounter this type error at runtime outside of the class itself.
Fixes GH-19304