Skip to content

ext/pdo_sqlite: explain statement prefixing with its class for errors. #18846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025
+3 −3
Merged

ext/pdo_sqlite: explain statement prefixing with its class for errors. #18846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/pdo_sqlite/sqlite_statement.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ static int pdo_sqlite_stmt_set_attribute(pdo_stmt_t *stmt, zend_long attr, zval
return 0;
}
if (Z_LVAL_P(zval) < 0 || Z_LVAL_P(zval) > 2) {
zend_value_error("explain mode must be one of the EXPLAIN_MODE_* constants");
zend_value_error("explain mode must be one of the Pdo\\Sqlite::EXPLAIN_MODE_* constants");
return 0;
}
if (sqlite3_stmt_explain(S->stmt, (int)Z_LVAL_P(zval)) != SQLITE_OK) {
Expand Down
4 changes: 2 additions & 2 deletions ext/pdo_sqlite/tests/subclasses/pdo_sqlite_getsetattr_explain.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,6 @@ array(2) {
}
explain mode must be of type int, string given
explain mode must be of type int, Duh given
explain mode must be one of the EXPLAIN_MODE_* constants
explain mode must be one of the EXPLAIN_MODE_* constants
explain mode must be one of the Pdo\Sqlite::EXPLAIN_MODE_* constants
explain mode must be one of the Pdo\Sqlite::EXPLAIN_MODE_* constants
bool(true)