ext/tidy: Various small refactoring #18774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On certain platform an unsigned int is 64bits, which is not needed.
devnexen
reviewed
Jun 5, 2025
nielsdos
approved these changes
Jun 5, 2025
Girgias
force-pushed
the
tidy-small-refactoring
branch
from
b390440 to
25b1908
Compare
devnexen
reviewed
Jun 5, 2025
| @@ -412,7 +408,7 @@ static void tidy_object_free_storage(zend_object *object) | |||
| if (intern->ptdoc) { | |||
| intern->ptdoc->ref_count--; | |||
|
|
|||
| if (intern->ptdoc->ref_count <= 0) { | |||
| if (intern->ptdoc->ref_count == 0) { | |||
There was a problem hiding this comment.
nice catch, seems a long forgotten change to me
devnexen
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits should be reviewed individually