Introduce OpenSSL INI for selecting libctx #18768
Open
+95
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Jun 5, 2025
bukka
force-pushed
the
openssl_libctx_ini
branch
from
80a6cc6 to
a79048d
Compare
bukka
added a commit
to bukka/php-src
that referenced
this pull request
Jun 20, 2025
Closes phpGH-18768 Co-authored-by: Gina Peter Banyard <girgias@php.net>
Closes phpGH-18768 Co-authored-by: Gina Peter Banyard <girgias@php.net>
bukka
force-pushed
the
openssl_libctx_ini
branch
from
a79048d to
4df6f23
Compare
SakiTakamachi
previously approved these changes
Jun 20, 2025
SakiTakamachi
dismissed
their stale review
Are the failing tests related to this change?
SakiTakamachi
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new INI that will allow fallback to default ctx. The plan is to actually initially use custom libctx only on ZTS by default and keep the default one for non-zts. The reason why it's not done in this PR is to allow CI to test the custom libctx.
In addition custom libctx now loads the config and also legacy provider if
LOAD_OPENSSL_LEGACY_PROVIDERdefined.There's been some minor init / globals refactoring done as well.