Skip to content

Zend/zend_hash: Add various NONNULL attributes #18511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
+311 −323
Draft

Zend/zend_hash: Add various NONNULL attributes #18511

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4f77528
Zend/zend_hash: Add various NONNULL attributes
Girgias May 6, 2025
b476591
ext/bz2: Fix nonnull warnings
Girgias May 6, 2025
1dd4023
ext/phar: Fix nonnull warnings
Girgias May 6, 2025
5ccbb96
ext/dba: Fix runtime nonnull warning
Girgias May 6, 2025
97b4eff
ext/zlib: Fix nonnull warnings
Girgias May 6, 2025
924f525
test dba change
Girgias May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test dba change
  • Loading branch information
@Girgias
Girgias committed May 7, 2025
commit 924f525c43f623e1db54d760040a01567366877c
7 changes: 4 additions & 3 deletions ext/dba/dba.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -974,12 +974,13 @@ PHP_FUNCTION(dba_close)
CHECK_DBA_CONNECTION(connection->info);

bool persistent = connection->info->flags & DBA_PERSISTENT;
void *info_ptr = connection->info;

dba_close_connection(connection);

if (persistent) {
zend_hash_apply_with_argument(&EG(persistent_list), remove_pconnection_from_list, (void *) connection->info);
zend_hash_apply_with_argument(&EG(persistent_list), remove_pconnection_from_list, info_ptr);
}

dba_close_connection(connection);
}
/* }}} */

Expand Down
Loading