Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-17836: zend_vm_gen.php shouldn't break on Windows line endings #18121

Closed
wants to merge 1 commit into from
Closed

GH-17836: zend_vm_gen.php shouldn't break on Windows line endings #18121

wants to merge 1 commit into from
+6 −0

Conversation

DanielEScherzer
Copy link
Member

No description provided.

@DanielEScherzer
Copy link
Member Author

CC @nielsdos

dstogov
dstogov approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@dstogov dstogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see problems

@nielsdos nielsdos closed this in fa3c1c8 Mar 21, 2025
@nielsdos
Copy link
Member

Merged into bugfix branches, thanks

@DanielEScherzer DanielEScherzer deleted the vm-gen-crlf branch March 21, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstogov dstogov dstogov approved these changes

@nielsdos nielsdos nielsdos approved these changes

Assignees
No one assigned
Labels
Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielEScherzer @nielsdos @dstogov