Fix GH-18114: pdo lazy object crash #18116
Merged
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Since 0537968, the properties are no longer initialized. So we call object_properties_init to handle that correctly. Lower branches have a memory leak, but that requires a separate fix.
devnexen
reviewed
Mar 19, 2025
ext/pdo/pdo_stmt.c
Outdated
| @@ -2405,6 +2406,7 @@ static zend_object *pdo_row_new(zend_class_entry *ce) | |||
| { | |||
| pdo_row_t *row = zend_object_alloc(sizeof(pdo_row_t), ce); | |||
| zend_object_std_init(&row->std, ce); | |||
| object_properties_init(&row->std, pdo_row_ce); | |||
There was a problem hiding this comment.
question ; would ce just work here ?
There was a problem hiding this comment.
Yep it would, in this case it's always the same. But it's cleaner to use ce. This is a copy-pasta leftover. Thanks for noticing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 0537968, the properties are no longer initialized. So we call object_properties_init to handle that correctly. Lower branches have a memory leak, but that requires a separate fix.