-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ext/bcmath: Improving bcpow()
performance
#18099
Open
SakiTakamachi
wants to merge
7
commits into
php:master
Choose a base branch
from
SakiTakamachi:bcmath/pow
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+209
−150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cff64b6
to
511010a
Compare
There were still some things I wanted to change, so I reverted it to a draft. |
33bfabf
to
f303bd5
Compare
Ready for review. cc: @nielsdos |
…dard_vector_mul`.
…e`, and renamed to `bc_square_vector`.
…c_multiply_vector
a1f6bbf
to
76d0e61
Compare
I force pushed by mistake. I'll open it again once I've confirmed the code 🙏 |
76d0e61
to
6d00b7b
Compare
6d00b7b
to
757e3bc
Compare
I reverted to the original code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran 500,000 comparisons with PHP 8.3 results. (I would like to perform more comparisons, but PHP 8.3's
bcpow()
is too heavy and the comparisons never finish.)No problems were detected.
Benchmarks
The speed difference is especially noticeable when
base
is less than 1 and there are many leading zeros.This is because try to eliminate as many zeros as possible during the calculation, and then fill in the missing digits with zeros later.
1:
2:
3:
4: