ext/standard/proc_open.c: Minor refactorings #18085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
force-pushed
the
proc_open_refactoring
branch
from
87e9c64 to
6e55f60
Compare
Girgias
force-pushed
the
proc_open_refactoring
branch
from
6e55f60 to
71a15f8
Compare
Add const modifier Use unsigned types when the source type is unsigned Use HashTable instead of zvals where possible
Girgias
force-pushed
the
proc_open_refactoring
branch
from
71a15f8 to
d40ea03
Compare
nielsdos
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add const modifier
Use unsigned types when the source type is unsigned