streams: Indicate which argument fails the stream ZPP check #18078
+101
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
force-pushed
the
stream-zpp-follow-up
branch
from
ee17ba3 to
10a7040
Compare
Girgias
force-pushed
the
stream-zpp-follow-up
branch
2 times, most recently
from
10a7040 to
a22959f
Compare
Girgias
force-pushed
the
stream-zpp-follow-up
branch
from
a22959f to
ec13ba7
Compare
nielsdos
reviewed
Mar 15, 2025
| *destination_stream_ptr = (php_stream*)res->ptr; | ||
| return true; | ||
| } else { | ||
| zend_argument_type_error(arg_num, "must be an open stream resource"); |
There was a problem hiding this comment.
open vs valid? The existing code uses valid instead of open, and this should be consistent imo.
Other parts of the PR look fine I think.
There was a problem hiding this comment.
The problem I find is that a closed stream still feels "valid" but will fail such a check. This is why I changed it to "open"
nielsdos
approved these changes
Mar 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.