Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GH-12231: SimpleXML xpath should warn when returning other return types than node lists #18073

Closed
wants to merge 1 commit into from
Closed

Fix GH-12231: SimpleXML xpath should warn when returning other return types than node lists #18073

wants to merge 1 commit into from
+57 −3

Conversation

nielsdos
Copy link
Member

See reasoning in issue.

@nielsdos nielsdos linked an issue Mar 15, 2025 that may be closed by this pull request
SimpleXML xpath should warn when returning other return types than node lists #12231
Closed
@nielsdos nielsdos marked this pull request as ready for review March 15, 2025 09:59
Girgias
Girgias approved these changes Mar 15, 2025
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSTM, can be elevated to a TypeError in a future release anyway.

@nielsdos nielsdos closed this in 86a67fe Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
Extension: simplexml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SimpleXML xpath should warn when returning other return types than node lists
2 participants
@nielsdos @Girgias