Minor improvements to ext/xml memory management #18071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah great, now Windows fails ffs |
Girgias
approved these changes
Mar 15, 2025
ext/xml/xml.c
Outdated
Comment on lines
676
to
679
| zend_string *stripped_tag = xml_stripped_tag(tag_name, parser->toffset); | ||
| xml_add_to_info(parser, stripped_tag); | ||
|
|
||
| add_assoc_string(&tag, "tag", skipped_tag_name); | ||
| add_assoc_str(&tag, "tag", stripped_tag); |
There was a problem hiding this comment.
It might be a good idea to add a comment to indicate that you are transferring the lifetime of the str to the tag array?
| @@ -749,17 +759,19 @@ void xml_endElementHandler(void *userData, const XML_Char *name) | |||
| add_assoc_string(zv, "type", "complete"); | |||
| } | |||
| } else { | |||
| char *skipped_tag_name = SKIP_TAGSTART(ZSTR_VAL(tag_name)); | |||
| zend_string *stripped_tag = xml_stripped_tag(tag_name, parser->toffset); | |||
ext/xml/xml.c
Outdated
Comment on lines
887
to
889
| zend_string *stripped_tag = xml_stripped_tag(parser->ltags[parser->level - 1], parser->toffset); | ||
| xml_add_to_info(parser, stripped_tag); | ||
| add_assoc_str(&tag, "tag", stripped_tag); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.