remove wrappers in session ext #18017
Merged
+92
−203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgsowa
force-pushed
the
session/remove-wrappers
branch
from
e574e4d to
1c7ce02
Compare
jorgsowa
force-pushed
the
session/remove-wrappers
branch
from
1c7ce02 to
f7cc969
Compare
Girgias
reviewed
Mar 11, 2025
|
I don't want to push it to other extensions. I want to finish PRs that I started in ext/session, and I wanted to get rid of those. I added back comments, although I think that they are redundant to the PHP documentation. But it's fine to keep them. |
The PHP documentation is not the source of truth, the C implementation is. I also just want to be able to understand what the C code does without hoping the PHP docs are sufficiently detailed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes comment wrappers in session ext. Unnecessary noise and AFAIK they are not used anymore.