gen_stub: various simplifications and clean up (3) #17886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
reviewed
Mar 8, 2025
The following properties are made private: * `ArrayType::$keyType`, `::$valueType` * `ArginfoType::$builtinTypes` * `ConstName::$const` * `ClassConstName::$const` * `PropertyName::$property` * `FuncInfo::$classFlags`, `::$isDeprecated`, `::$supportsCompileTimeEval`, `::$minimumPhpVersionIdCompatibility`, `::$framelessFunctionInfos`, `::$exposedDocComment` * `VariableLike::$link` * `ConstInfo::$isDeprecated`, `::$valueString`, `::$isFileCacheAllowed` * `PropertyInfo::$classFlags`, `::$defaultValue`, `::$defaultValueString`, `::$isDocReadonly`, `::$isVirtual` * `EnumCaseInfo::$name`, `::$value` * `AttributeInfo::$args` * `ClassInfo::$enumBackingType`, `::$isDeprecated`, `::$exposedDocComment`, `::$isStrictProperties`, `::$isNotSerializable`, `::$propertyInfos`, `::$enumCaseInfos` The following are made protected: * `VariableLike::$exposedDocComment`, `::$phpVersionIdMinimumCompatibility`
Move the logic from `parseStubFile()` to `FileInfo::__construct()`, and in the process inline and remove `FileInfo::setMinimumPhpVersionIdCompatibility()`.
Unused, only caller passes in the same FuncInfo object that the method is called on.
Deduplicate reporting out each time a file is saved
They are immutable
Reduce the number of global functions by moving it to `ExposedDocComment::extractExposedComment()`
Reduce the number of global functions merging `parseDocComment()` into its only caller
Reduce the number of global functions by moving it to `AttributeInfo::createFromGroups()`. In the process, fix the documentation for the return type, the result is an array of `AttributeInfo` objects, not `Attribute` objects.
Reduce the number of global functions by moving it to instance method `FuncInfo::findEquivalent()`.
DanielEScherzer
force-pushed
the
stub-simplify-3
branch
from
6a7982e to
b98a88f
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each commit can be reviewed independently, and should have no functional changes