Reflection: indicate final and abstract properties in string output #17827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @iluuu1994 - my understanding is that final properties was added as a part of property hooks |
iluuu1994
reviewed
Feb 18, 2025
DanielEScherzer
force-pushed
the
reflection-prop-final
branch
from
438de46 to
1334776
Compare
Added I didn't send this to 8.4 originally since it isn't really a bug, but retargeted. I was planning to also work on some kind of indication of property hooks in a follow-up, should that also go to 8.4? |
|
I would classify this as a bug. Whether your other PR should target 8.4 depends on whether it's a bug. 😄 |
iluuu1994
reviewed
Feb 24, 2025
Add "final" and "abstract" to the result of `_property_string()` when outputting the string representation of a `ReflectionClass` or `ReflectionProperty` instance
DanielEScherzer
force-pushed
the
reflection-prop-final
branch
from
1334776 to
b4f19dd
Compare
DanielEScherzer
changed the title
|
Fixed whitespace and squashed the commits |
|
Thank you @DanielEScherzer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "final" and "abstract" to the result of
_property_string()when outputting the string representation of aReflectionClassorReflectionPropertyinstance