Skip to content

RFC: Marking return values as important (#[\NoDiscard]) #17599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 2, 2025
Merged

RFC: Marking return values as important (#[\NoDiscard]) #17599

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0d83f7a
Add `#[\NoDiscard]` attribute definition
TimWolla Mar 20, 2025
6f7aec5
Apply `#[\NoDiscard]` to `\DateTimeImmutable::set*()`
TimWolla Mar 20, 2025
5fcdd24
Apply `#[\NoDiscard]` to `flock()`
TimWolla Mar 20, 2025
c9c7e08
Add `ZEND_ACC_NODISCARD` flag
TimWolla Mar 20, 2025
a9db173
Add compile-time restrictions on `#[\NoDiscard]` usage
TimWolla Mar 20, 2025
526e6f3
Make `ZEND_ACC_NODISCARD` functional
TimWolla Dec 18, 2024
1bd1d6c
Leverage RETVAL opcode specialization
TimWolla Jan 24, 2025
368e73d
JIT support
TimWolla Jan 28, 2025
609fcf5
Keep optimized opcodes if the result is known-used
TimWolla Mar 26, 2025
80df976
Merge branch 'master' into return-value-unused
TimWolla Apr 1, 2025
1f73af0
Merge branch 'master' into return-value-unused
TimWolla Apr 2, 2025
08222df
Remove useless refcounting of `message` in `get_nodiscard_suffix_from…
TimWolla Apr 2, 2025
97f3f17
NEWS / UPGRADING
TimWolla Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove useless refcounting of message in `get_nodiscard_suffix_from… 
…_attribute()`
  • Loading branch information
@TimWolla
TimWolla committed Apr 2, 2025
commit 08222df3083301946e01fa205a1faa5164b2682b
3 changes: 1 addition & 2 deletions Zend/zend_execute.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1942,7 +1942,7 @@ ZEND_COLD static zend_result ZEND_FASTCALL get_nodiscard_suffix_from_attribute(H
z = zend_read_property_ex(zend_ce_nodiscard, Z_OBJ_P(&obj), ZSTR_KNOWN(ZEND_STR_MESSAGE), false, NULL);
ZEND_ASSERT(z != &EG(uninitialized_zval));
if (Z_TYPE_P(z) == IS_STRING) {
message = zend_string_copy(Z_STR_P(z));
message = Z_STR_P(z);
}

/* Construct the suffix. */
Expand All @@ -1957,7 +1957,6 @@ ZEND_COLD static zend_result ZEND_FASTCALL get_nodiscard_suffix_from_attribute(H

out:

zend_string_release(message);
zval_ptr_dtor(&obj);

return result;
Expand Down