Fix gh15937.phpt #17315
Closed
Fix gh15937.phpt #17315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test is supposed to fail, because the timeout is too large. Thus we fix the test expectation, and also convert the test to use the CLI test server to not require online availability.
|
Is the timeout actually fixed in 8.2? It's failing... |
|
Ah! The test without modifications actually passes on PHP-8.2, but fails as of PHP-8.3 (due to checking for large timeout values). So the best course of actions seems to make the test offline for PHP-8.2, but to drop it for PHP-8.3 and up. |
charmitro
pushed a commit
to wasix-org/php
that referenced
this pull request
Mar 13, 2025
We convert the test to use the CLI test server to not require online availability. As of PHP 8.3, the test is supposed to fail, because the timeout is too large. Since exactly this scenario is already tested by gh16810.phpt, we drop the test for PHP-8.3 and up. Closes phpGH-17315.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is supposed to fail, because the timeout is too large. Thus we fix the test expectation, and also convert the test to use the CLI test server to not require online availability.
Given that this test case is basically a duplicate of gh16810.phpt (see #17314), but the latter is only available as of PHP-8.3, we should either drop gh15937.phpt in PHP-8.3 and above, or backport gh16810.phpt to PHP-8.2, and drop gh15937.phpt altogether.