Fix bug #45282: SoapClient has namespace issues when WSDL is distributed #15842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdos
force-pushed
the
soap-45282
branch
8 times, most recently
from
57a39c1 to
2b5e021
Compare
By having a newline in there, we get whitespace in the namespace uri, which is incorrect.
targetNamespace and tns do not match, which means that the lookup for the messages in tns should fail. However, due to a bug this currently doesn't fail. This will fail in the future after a bugfix.
We're ignoring the namespaces that the messages, ports, bindings and services are defined in when registering them. Consequently, we're also ignoring the namespace component of the QName when looking up references. This patch solves this issue by introducing a new qname_hash_table type along with two methods to add and query the table. Internally, it's a nested HashTable where the outer layer is the namespace uri and the inner layer is the local name. It's worth pointing out that at least one comment in the original issue points to a WSDL that actually has a validation issue because it has two messages with the same local name in the same namespace, so in that case PHP's SOAP client is actually correct. The other links in the comments no longer exist, but I was able to reconstruct the issue based on reading the report and by cross-checking the expected behaviour with the WSDL spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes one of the oldest highest voted SOAP bugs: https://bugs.php.net/bug.php?id=45282