Skip to content

Autotools: Move PHP_ODBC_* defines to configuration header #15708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

petk
Copy link
Member

@petk petk commented Sep 2, 2024

The PHP_ODBC_* defines are remains of the PHP 2 and 3 era where the ODBC functionality was part of the PHP core and was later moved to an extension. This moves these defines to a regular PHP configuration header as done in other extensions.

Targeted after PHP-8.4.

@petk petk added this to the PHP 9 milestone Sep 2, 2024
The PHP_ODBC_* defines are remains of the PHP 2 and 3 era where the ODBC
functionality was part of the PHP core and was later moved to an
extension. This moves these defines to a regular PHP configuration
header (php_config.h) as done in other extensions.
@petk petk force-pushed the patch-ODBC-defines branch from 6b3a69b to b1b8059 Compare June 19, 2025 13:01
@petk petk removed this from the PHP 9 milestone Jun 19, 2025
@petk
Copy link
Member Author

petk commented Jun 19, 2025

I've removed the PHP 9 milestone as these versions got really out of understanding what comes after 8.4. So targeting current master here. I haven't found any case where these should be added to build-defs.h header so merge coming up here sometimes soon then if everyone's fine with this.

@Girgias
Copy link
Member

Girgias commented Jun 19, 2025

I think you are fine to merge this @petk

@petk
Copy link
Member Author

petk commented Jun 19, 2025

Otherwise, it would be actually even better to completely remove the PHP_ODBC_{CFLAGS,LFLAGS,LIBS} but this can be done at some later version I think. Because this kind of information is not so important for the user of odbc extension and hardcodes the compile-time info into the binary making various PHP configurations (debug, release, install prefix, etc.) harder to use and install... Anyway these kind of issues some time later.

@petk petk merged commit 49dd619 into php:master Jun 19, 2025
9 checks passed
@petk petk deleted the patch-ODBC-defines branch June 19, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants