Use a common function for "cannot be empty" ValueError #15489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Extension: openssl
Category: Engine
Extension: intl
Extension: bz2
Extension: dba
Extension: dom
Extension: enchant
Extension: exif
Extension: fileinfo
Extension: gd
Extension: gettext
Extension: hash
Extension: ldap
Extension: mbstring
Extension: mysqli
Extension: pcntl
Extension: pdo (core)
Extension: pdo_pgsql
Extension: pdo_sqlite
Extension: pgsql
Extension: posix
Extension: simplexml
Extension: soap
Extension: spl
Extension: sqlite3
Extension: standard
Extension: xmlreader
Extension: xmlwriter
Extension: zip
Extension: random
labels
|
Girgias
force-pushed
the
helpers-common-value-error-empty
branch
from
4f11fa2 to
314410f
Compare
youkidearitai
approved these changes
Aug 19, 2024
devnexen
approved these changes
Aug 19, 2024
nielsdos
reviewed
Aug 19, 2024
| @@ -14,4 +14,4 @@ try { | |||
| } | |||
| ?> | |||
| --EXPECT-- | |||
| DOMDocument::loadHTML(): Argument #1 ($source) must not be empty | |||
| DOMDocument::loadHTML(): Argument #1 ($source) cannot be empty | |||
Girgias
force-pushed
the
helpers-common-value-error-empty
branch
from
89e35ad to
c47d283
Compare
It not being empty is already checked by PHP_GETTEXT_DOMAIN_LENGTH_CHECK()
Girgias
force-pushed
the
helpers-common-value-error-empty
branch
from
c47d283 to
34b57c9
Compare
nielsdos
reviewed
Aug 21, 2024
Zend/zend_API.c
Outdated
| @@ -439,6 +439,11 @@ ZEND_API ZEND_COLD void zend_argument_value_error(uint32_t arg_num, const char * | |||
| } | |||
| /* }}} */ | |||
|
|
|||
| ZEND_API ZEND_COLD void zend_argument_cannot_be_empty_error(uint32_t arg_num) | |||
There was a problem hiding this comment.
The function name now no longer matches the message.
There was a problem hiding this comment.
Updated in-place in the last commit, which changes the wording from "cannot" to "must not"
Girgias
force-pushed
the
helpers-common-value-error-empty
branch
from
34b57c9 to
c823ee4
Compare
nielsdos
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits should be reviewed individually.
Some extensions were not using the standard wording, so changed it by using the new helper.
There are also some drive-by refactoring that I noticed while changing the code to use the helper.