session_create_id - error message for large prefix #15338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
reviewed
Aug 11, 2024
Girgias
reviewed
Aug 11, 2024
ext/session/session.c
Outdated
Comment on lines
2389
to
2393
| /* E_ERROR raised for security reason. */ | ||
| php_error_docref(NULL, E_WARNING, "Prefix cannot contain special characters. Only the A-Z, a-z, 0-9, \"-\", and \",\" characters are allowed"); | ||
| RETURN_FALSE; |
There was a problem hiding this comment.
Hum, the comment is leading me to believe that this should be an exception
jorgsowa
force-pushed
the
session_prefix_id_larger_than_256
branch
from
5c9e5aa to
0a2b1a2
Compare
Girgias
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds exclusive error message for prefixes larger than 256 characters. Currently, it shows the wrong message
Prefix cannot contain special characters. Only the A-Z, a-z, 0-9....