Skip to content

Conversation

@petk
Copy link
Member

@petk petk commented Jul 27, 2024

This macro once had also the 5th argument (the build target), which was removed via 2a6da0f. This quotes all PHP_SELECT_SAPI arguments and removes the redundant ones. The basic macro usage help text is moved to the macros section from the obsolete docs file.

This macro once had also the 5th argument (the build target), which was
removed via 2a6da0f. This quotes all
PHP_SELECT_SAPI arguments and removes the redundant ones. The basic
macro usage help text is moved to the macros section from the obsolete
docs file.
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCTM

@petk petk merged commit 003e238 into php:master Jul 27, 2024
@petk petk deleted the patch-PHP_SELECT_SAPI branch July 27, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants